Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update katib-config.md #3888

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Update katib-config.md #3888

merged 3 commits into from
Sep 30, 2024

Conversation

Rajakavitha1
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 commented Sep 29, 2024 •
edited
Loading

Fixes #3811 and #3813

@Rajakavitha1
Update katib-config.md
ccbe26e 
Signed-off-by: Rajakavitha Kodhandapani <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

Hi @Rajakavitha1. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rajakavitha1
Update netlify.toml
07acff1 
Signed-off-by: Rajakavitha Kodhandapani <[email protected]>
@Rajakavitha1
Update architecture.md
f9eb5b1 
Signed-off-by: Rajakavitha Kodhandapani <[email protected]>
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Sep 29, 2024
@Rajakavitha1 Rajakavitha1 marked this pull request as ready for review September 29, 2024 08:19
@Rajakavitha1 Rajakavitha1 mentioned this pull request Sep 29, 2024
Open
hbelmiro
hbelmiro reviewed Sep 29, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 29, 2024
@hbelmiro
Copy link
Contributor

/ok-to-test

@hbelmiro hbelmiro mentioned this pull request Sep 29, 2024
Open
6 tasks
@hbelmiro
Copy link
Contributor

cc @andreyvelich @johnugeorge

andreyvelich
andreyvelich reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Rajakavitha1!

netlify.toml
@@ -34,8 +34,6 @@ package = "netlify-plugin-checklinks"
"public/docs/components/pipelines/fonts/",
"public/docs/components/pipelines/legacy-v1/fonts/",

"public/docs/components/katib/",
"public/docs/components/kfserving/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we update the KFServing docs ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It seems like the broken link was fixed in another PR, but KFServing was not removed from the white list.
Since there are no more broken links (we can confirm it in the CI of this PR), it should be removed.

@andreyvelich
Copy link
Member

/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4115c6a into kubeflow:master Sep 30, 2024
6 checks passed
@hbelmiro hbelmiro mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@hbelmiro hbelmiro hbelmiro left review comments

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@hbelmiro hbelmiro

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken links in Katib
3 participants
@Rajakavitha1 @hbelmiro @andreyvelich